From 232bb5eb960a2220baef8d78df02814c657e8a13 Mon Sep 17 00:00:00 2001 From: Erin Call Date: Thu, 26 Dec 2019 13:03:53 -0800 Subject: [PATCH] Rely on the PR template for docs/code consistency [#12] These comments were a reasonable attempt at ensuring the documentation matched reality, but the checkbox in the pull request template is much more likely to produce results. --- internal/helm/plan.go | 1 - internal/run/lint.go | 2 -- internal/run/upgrade.go | 2 -- 3 files changed, 5 deletions(-) diff --git a/internal/helm/plan.go b/internal/helm/plan.go index 54de589..e6c8721 100644 --- a/internal/helm/plan.go +++ b/internal/helm/plan.go @@ -69,7 +69,6 @@ func determineSteps(cfg Config) *func(Config) []Step { return &help default: switch cfg.DroneEvent { - // Note: These events are documented in docs/upgrade_settings.yml. Any changes here should be reflected there. case "push", "tag", "deployment", "pull_request", "promote", "rollback": return &upgrade case "delete": diff --git a/internal/run/lint.go b/internal/run/lint.go index 1993b49..e2843ca 100644 --- a/internal/run/lint.go +++ b/internal/run/lint.go @@ -16,8 +16,6 @@ func (l *Lint) Execute(_ Config) error { } // Prepare gets the Lint ready to execute. -// Note: mandatory settings are documented in README.md, and the full list of settings is in docs/lint_settings.yml. -// Any additions or deletions here should be reflected there. func (l *Lint) Prepare(cfg Config) error { if l.Chart == "" { return fmt.Errorf("chart is required") diff --git a/internal/run/upgrade.go b/internal/run/upgrade.go index fc561aa..dd50527 100644 --- a/internal/run/upgrade.go +++ b/internal/run/upgrade.go @@ -25,8 +25,6 @@ func (u *Upgrade) Execute(_ Config) error { } // Prepare gets the Upgrade ready to execute. -// Note: mandatory settings are documented in README.md, and the full list of settings is in docs/upgrade_settings.yml. -// Any additions or deletions here should be reflected there. func (u *Upgrade) Prepare(cfg Config) error { if u.Chart == "" { return fmt.Errorf("chart is required")