From 84ac01983869703f82589dbc110299d54d09ee33 Mon Sep 17 00:00:00 2001 From: Erin Call Date: Wed, 18 Dec 2019 10:38:33 -0800 Subject: [PATCH] Add the --namespace flag in Lint.Prepare [#3] I don't know whether this is necessary; I'm just following drone-helm's lead. At worst, helm will accept the flag, so it's at least *safe* to include. --- internal/run/lint.go | 3 +++ internal/run/lint_test.go | 27 +++++++++++++++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/internal/run/lint.go b/internal/run/lint.go index aa18128..620bc35 100644 --- a/internal/run/lint.go +++ b/internal/run/lint.go @@ -24,6 +24,9 @@ func (l *Lint) Prepare(cfg Config) error { args := make([]string, 0) + if cfg.Namespace != "" { + args = append(args, "--namespace", cfg.Namespace) + } if cfg.Debug { args = append(args, "--debug") } diff --git a/internal/run/lint_test.go b/internal/run/lint_test.go index 9f88598..b3881bd 100644 --- a/internal/run/lint_test.go +++ b/internal/run/lint_test.go @@ -134,3 +134,30 @@ func (suite *LintTestSuite) TestPrepareWithDebugFlag() { want := fmt.Sprintf("Generated command: '%s --debug lint ./scotland/top_40'\n", helmBin) suite.Equal(want, stderr.String()) } + +func (suite *LintTestSuite) TestPrepareWithNamespaceFlag() { + defer suite.ctrl.Finish() + + cfg := Config{ + Namespace: "table-service", + } + + l := Lint{ + Chart: "./wales/top_40", + } + + actual := []string{} + command = func(path string, args ...string) cmd { + actual = args + return suite.mockCmd + } + + suite.mockCmd.EXPECT().Stdout(gomock.Any()) + suite.mockCmd.EXPECT().Stderr(gomock.Any()) + + err := l.Prepare(cfg) + suite.Require().Nil(err) + + expected := []string{"--namespace", "table-service", "lint", "./wales/top_40"} + suite.Equal(expected, actual) +}