From dbcef2699e026b3aabc97b418234d83fd0425985 Mon Sep 17 00:00:00 2001 From: Erin Call Date: Tue, 21 Jan 2020 16:25:58 -0800 Subject: [PATCH] Avoid polluted-env problems in config tests [#34] I mean...it's *possible* someone will have SECRET_WATER set in their env, right? Might as well be paranoid; it doesn't cost much. --- internal/env/config_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/internal/env/config_test.go b/internal/env/config_test.go index 4288342..15510e0 100644 --- a/internal/env/config_test.go +++ b/internal/env/config_test.go @@ -186,6 +186,7 @@ func (suite *ConfigTestSuite) TestLogDebugCensorsKubeToken() { func (suite *ConfigTestSuite) TestNewConfigWithValuesSecrets() { suite.unsetenv("VALUES") suite.unsetenv("STRING_VALUES") + suite.unsetenv("SECRET_WATER") suite.setenv("SECRET_FIRE", "Eru_Ilúvatar") suite.setenv("SECRET_RINGS", "1") suite.setenv("PLUGIN_VALUES", "fire=$SECRET_FIRE,water=${SECRET_WATER}") @@ -200,6 +201,7 @@ func (suite *ConfigTestSuite) TestNewConfigWithValuesSecrets() { func (suite *ConfigTestSuite) TestValuesSecretsWithDebugLogging() { suite.unsetenv("VALUES") + suite.unsetenv("SECRET_WATER") suite.setenv("SECRET_FIRE", "Eru_Ilúvatar") suite.setenv("PLUGIN_DEBUG", "true") suite.setenv("PLUGIN_STRING_VALUES", "fire=$SECRET_FIRE")