dentaku/woodpecker-helm3
1
0
Fork 0
Code Pull requests Releases Activity

Use "backward-compatible", not "backwardS"

Browse source 
While writing docs in the previous commit, I noticed that we'd been
inconsistent in the naming scheme. Wikipedia's back-compat article
redirects from "backwards" to "backward", so I figure that's a
reasonable source of authority for which form to use.
This commit is contained in:
Erin Call 2020-01-08 11:04:30 -08:00
parent a5342d7bac
commit cfd8e33995
No known key found for this signature in database
GPG key ID: 4071FF6C15B8DAD1
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
README.md
View file

@ -10,7 +10,7 @@ This plugin provides an interface between [Drone](https://drone.io/) and [Helm 3
* Deploy your service * Deploy your service
* Delete your service * Delete your service
The plugin is inpsired by [drone-helm](https://github.com/ipedrazas/drone-helm), which fills the same role for Helm 2. It provides a comparable feature-set and the configuration settings are backwards-compatible. The plugin is inpsired by [drone-helm](https://github.com/ipedrazas/drone-helm), which fills the same role for Helm 2. It provides a comparable feature-set and the configuration settings are backward-compatible.
## Example configuration ## Example configuration
@ -60,7 +60,7 @@ steps:
## Upgrading from drone-helm ## Upgrading from drone-helm
drone-helm3 is largely backwards-compatible with drone-helm. There are some known differences: drone-helm3 is largely backward-compatible with drone-helm. There are some known differences:
* You'll need to migrate the deployments in the cluster [helm-v2-to-helm-v3](https://helm.sh/blog/migrate-from-helm-v2-to-helm-v3/). * You'll need to migrate the deployments in the cluster [helm-v2-to-helm-v3](https://helm.sh/blog/migrate-from-helm-v2-to-helm-v3/).
* EKS is not supported. See [#5](https://github.com/pelotech/drone-helm3/issues/5) for more information. * EKS is not supported. See [#5](https://github.com/pelotech/drone-helm3/issues/5) for more information.

2
internal/helm/plan_test.go
View file

@ -370,7 +370,7 @@ func (suite *PlanTestSuite) TestDeterminePlanUninstallCommand() {
suite.Same(&uninstall, stepsMaker) suite.Same(&uninstall, stepsMaker)
} }
// helm_command = delete is provided as an alias for backwards-compatibility with drone-helm // helm_command = delete is provided as an alias for backward-compatibility with drone-helm
func (suite *PlanTestSuite) TestDeterminePlanDeleteCommand() { func (suite *PlanTestSuite) TestDeterminePlanDeleteCommand() {
cfg := Config{ cfg := Config{
Command: "delete", Command: "delete",