add skip-crds flag support

Signed-off-by: George Kaz <egeorgekaz@gmail.com>
This commit is contained in:
George Kaz 2021-07-20 19:21:44 +01:00
parent 8dba329407
commit e482a144c1
5 changed files with 32 additions and 1 deletions

View file

@ -1,4 +1,4 @@
FROM alpine/helm:3.2.4
FROM alpine/helm:3.6.2
MAINTAINER Erin Call <erin@liffft.com>
COPY build/drone-helm /bin/drone-helm

View file

@ -50,6 +50,7 @@ Installations are triggered when the `mode` setting is "upgrade." They can also
| reuse_values | boolean | | | Reuse the values from a previous release. |
| skip_tls_verify | boolean | | | Connect to the Kubernetes cluster without checking for a valid TLS certificate. Not recommended in production. This is ignored if `skip_kubeconfig` is `true`. |
| create_namespace | boolean | | | Pass --create-namespace to `helm upgrade`. |
| skip_crds | boolean | | | Pass --skip-crds to `helm upgrade`. |
## Uninstallation

View file

@ -52,6 +52,7 @@ type Config struct {
AtomicUpgrade bool `split_words:"true"` // Pass --atomic to `helm upgrade`
CleanupOnFail bool `envconfig:"cleanup_failed_upgrade"` // Pass --cleanup-on-fail to `helm upgrade`
LintStrictly bool `split_words:"true"` // Pass --strict to `helm lint`
SkipCrds bool `split_words:"true"` // Pass --skip-crds to `helm upgrade`
Stdout io.Writer `ignored:"true"`
Stderr io.Writer `ignored:"true"`

View file

@ -24,6 +24,7 @@ type Upgrade struct {
cleanupOnFail bool
certs *repoCerts
createNamespace bool
skipCrds bool
cmd cmd
}
@ -47,6 +48,7 @@ func NewUpgrade(cfg env.Config) *Upgrade {
cleanupOnFail: cfg.CleanupOnFail,
certs: newRepoCerts(cfg),
createNamespace: cfg.CreateNamespace,
skipCrds: cfg.SkipCrds,
}
}
@ -100,6 +102,9 @@ func (u *Upgrade) Prepare() error {
if u.createNamespace {
args = append(args, "--create-namespace")
}
if u.skipCrds {
args = append(args, "--skip-crds")
}
for _, vFile := range u.valuesFiles {
args = append(args, "--values", vFile)
}

View file

@ -220,3 +220,27 @@ func (suite *UpgradeTestSuite) TestPrepareDebugFlag() {
suite.Equal(want, stderr.String())
suite.Equal("", stdout.String())
}
func (suite *UpgradeTestSuite) TestPrepareSkipCrdsFlag() {
defer suite.ctrl.Finish()
cfg := env.Config{
Chart: "at40",
Release: "cabbages_smell_great",
SkipCrds: true,
}
u := NewUpgrade(cfg)
command = func(path string, args ...string) cmd {
suite.Equal(helmBin, path)
suite.Equal([]string{"upgrade", "--install", "--skip-crds", "cabbages_smell_great", "at40"}, args)
return suite.mockCmd
}
suite.mockCmd.EXPECT().Stdout(gomock.Any())
suite.mockCmd.EXPECT().Stderr(gomock.Any())
err := u.Prepare()
suite.Require().Nil(err)
}