Erin Call
1f7b6bb389
Add a setting for chart repository CA certificates [ #74 ]
2020-01-20 09:15:56 -08:00
Erin Call
8c6c6fbfa5
CleanupOnFail option for the upgrade Step [ #65 ]
2020-01-07 12:53:55 -08:00
Erin Call
971e3f17cb
Atomic option for the Upgrade step [ #64 ]
2020-01-07 12:17:54 -08:00
Erin Call
8d8bcf78a7
Merge branch 'master' into keep-history
2020-01-02 13:26:53 -08:00
Erin Call
45428a2e25
Merge branch 'master' into keep-history
2020-01-02 12:29:32 -08:00
Erin Call
7b816ea257
Merge branch 'master' into values-arent-global
2020-01-02 12:29:15 -08:00
Erin Call
4330728215
Put step-specific config in those steps [ #61 ]
...
This is just something that's been bugging me for a while--they're
specific to Lint and Upgrade, so that's where they belong.
2020-01-02 11:38:41 -08:00
Erin Call
3ae13d4b3c
Pass --strict to helm lint
when so instructed [ #28 ]
2020-01-02 11:25:13 -08:00
Erin Call
17724e7015
Pass --keep-history when so instructed [ #24 ]
2020-01-02 10:58:58 -08:00
Erin Call
3985ec8faa
Merge branch 'master' into helm-repos
2019-12-30 13:29:23 -08:00
Erin Call
499ab6877f
Do repo error-checking in AddRepo.Prepare [ #26 ]
2019-12-30 13:24:57 -08:00
Erin Call
9155d5eeeb
Merge branch 'master' into helm-repos
2019-12-30 09:56:18 -08:00
Erin Call
75c99683b5
AddRepo step that calls helm repo add
[ #26 ]
...
As with some of the other commands, I'm not sure `--namespace` is
relevant here. Just rolling with the "at worst it doesn't hurt" theory.
2019-12-30 09:52:00 -08:00
Joachim Hill-Grannec
eb1834df49
Merge branch 'master' into help-by-default
2019-12-28 09:31:04 -07:00
Erin Call
181165cc51
Call helm dependency update
when so instructed [ #25 ]
...
As with Lint, I have no idea whether the --namespace flag actually
matters here. I don't think it will hurt, though!
2019-12-27 15:06:32 -08:00
Erin Call
232bb5eb96
Rely on the PR template for docs/code consistency [ #12 ]
...
These comments were a reasonable attempt at ensuring the documentation
matched reality, but the checkbox in the pull request template is much
more likely to produce results.
2019-12-26 13:03:53 -08:00
Erin Call
818c0246fa
Merge branch 'master' into help-by-default
2019-12-26 13:00:13 -08:00
Erin Call
3b85c38714
Test yaml validity without a new dependency [ #15 ]
...
It turns out testify already depends on yaml, so we aren't adding
anything new by using it here.
2019-12-26 12:53:36 -08:00
Erin Call
1422ec77a4
Merge branch 'master' into kubeconfig-tests
2019-12-26 12:50:00 -08:00
Erin Call
2a13fff548
Don't check the generated config's yaml syntax [ #13 ]
...
See discussion on https://github.com/pelotech/drone-helm3/pull/36 --it
doesn't really make sense to add a dependency on yaml just for testing.
2019-12-26 12:39:02 -08:00
Erin Call
167b53691b
Put HelmCommand in Help, not run.Config [ #15 ]
2019-12-26 12:23:56 -08:00
Erin Call
b1899dee56
Merge remote-tracking branch 'origin/master' into help-by-default
2019-12-26 12:23:14 -08:00
Erin Call
b2066961e1
Merge branch 'master' into kubeconfig-tests
2019-12-26 11:55:32 -08:00
Joachim Hill-Grannec
253a4465f8
Merge branch 'master' into config-fixup
2019-12-26 11:36:55 -08:00
Erin Call
6d28b7b28a
Return an error on unknown commands [ #15 ]
...
I'm probably overthinking this--explicitly calling help is a strange and
unusual case--but it doesn't really hurt, so I'm going for it.
2019-12-26 11:29:33 -08:00
Joachim Hill-Grannec
81c4877a92
Merge branch 'master' into noncompulsory-certificate
2019-12-26 11:27:43 -08:00
Erin Call
6b331fdf03
Check the validity of the kubeconfig template [ #13 ]
...
It's a little tricky to find a balance between "brittle" and "thorough"
in this test--I'd like to verify that e.g. the certificate is in
clusters[0].cluster.certificate-authority-data, not at the root. On the
other hand, we can't actually show that it's a valid kubeconfig file
without actually *using* it, so there's a hard upper limit on the
strength of the assertions. I've settled on verifying that all the
settings make it into the file and the file is syntactically-valid yaml.
2019-12-25 10:11:14 -08:00
Erin Call
4755f502b5
Always use the default kubeconfig file path [ #20 ]
2019-12-23 12:47:16 -08:00
Erin Call
3eb90651d1
Rough-draft upgrade settings documentation [ #8 ]
2019-12-23 09:49:01 -08:00
Erin Call
dc4ecb6b91
Allow an empty Certificate setting [ #29 ]
...
I just plain misunderstood how kubernetes CAs worked!
2019-12-20 16:11:20 -08:00
Erin Call
197a377a82
Prod maintainers to keep the docs and code in sync [ #8 ]
...
Offhand I don't see a way to ensure it programmatically, but I feel like
I should at least make an attempt.
2019-12-20 10:05:50 -08:00
Erin Call
161960e55e
Rename Delete to Uninstall [ #4 ]
...
Helm3 renamed its delete command to uninstall. We should still accept
helm_command=delete for drone-helm compatibility, but the internals
should use Helm's preferred name.
2019-12-19 15:04:33 -08:00
Erin Call
68a2c3cc86
Merge branch 'master' into helm-delete
2019-12-19 11:34:44 -08:00
Erin Call
7849b28532
Format the Delete struct less weirdly [ #4 ]
...
I thought it was a golang style convention to put a blank line between
public and private struct fields, but apparently I imagined that.
2019-12-19 11:11:50 -08:00
Erin Call
c033c8c45e
Format the Lint struct non-weirdly [ #3 ]
...
I thought it was a golang style convention to put a blank line between
public and private struct fields, but apparently I imagined that.
2019-12-19 11:09:39 -08:00
Erin Call
30e1e3b99f
Assert that Lint.Prepare sets cmd.Stdout/Stderr [ #3 ]
2019-12-19 10:26:33 -08:00
Erin Call
b93917c857
Use better expectations in lint_test [ #3 ]
...
The tests need to allow calls to Stdout/Stderr so they don't get
"Unexpected call" errors from gomock, but these tests aren't meant to
assert that the calls actually happened. Using .AnyTimes allows 0 or
more calls.
2019-12-19 10:21:11 -08:00
Erin Call
a21d6ad61f
Implement a Delete Step [ #4 ]
2019-12-18 11:47:15 -08:00
Erin Call
84ac019838
Add the --namespace flag in Lint.Prepare [ #3 ]
...
I don't know whether this is necessary; I'm just following drone-helm's
lead. At worst, helm will accept the flag, so it's at least *safe* to
include.
2019-12-18 10:38:33 -08:00
Erin Call
a6a2d6e6a3
Require a nonempty chart in Lint.Prepare [ #3 ]
2019-12-17 17:01:22 -08:00
Erin Call
a6b7e06bd2
Implement the debug flag in lint [ #3 ]
2019-12-17 17:01:18 -08:00
Erin Call
51800c18d7
Implement the various values flags in lint [ #3 ]
2019-12-17 17:01:11 -08:00
Erin Call
991bbf97b4
Create a Lint step [ #3 ]
...
Still need global flags and checks for mandatory settings, but the basic
functionality is there.
2019-12-17 17:01:06 -08:00
Erin Call
1560c05100
Fail early if chart or release is missing
2019-12-16 17:02:56 -08:00
Erin Call
e4fa70239e
Implement config flags for helm upgrade
2019-12-16 16:55:05 -08:00
Erin Call
13c663e906
Initialize kubernetes config on upgrade
...
This change revealed more about how the system needs to work, so there
are some supporting changes:
* helm.upgrade and helm.help are now vars rather than raw functions.
This allows unit tests to target the "which step should we run"
logic directly by comparing function pointers, rather than having to
configure/prepare a fully-valid Plan and then infer the logic’s
correctness based on the Plan’s state.
* configuration that's specific to kubeconfig initialization is now part
of the InitKube struct rather than run.Config, since other steps
shouldn’t need access to those settings (particularly the secrets).
* Step.Execute now receives a run.Config so it can log debug output.
2019-12-16 15:41:04 -08:00
Erin Call
4cbb4922fb
Implement the debug flag and help command
...
I'm vacillating about the choice to have separate Config structs in the
`helm` and `run` packages. I can't tell whether it's "good separation of
concerns" or "cumbersome and over-engineered." It seems appropriate at
the moment, though.
2019-12-10 15:33:50 -08:00
Erin Call
8d66036252
Brush all the lint off this code I wrote in a haze
2019-12-09 10:53:32 -08:00
Erin Call
e3051ec72e
Replicate most of drone-helm's config
2019-12-09 09:58:42 -08:00
Erin Call
238ede6f9e
Actual drone-invokable helm commands
2019-12-05 14:35:25 -08:00