13c663e906
This change revealed more about how the system needs to work, so there
are some supporting changes:
* helm.upgrade and helm.help are now vars rather than raw functions.
This allows unit tests to target the "which step should we run"
logic directly by comparing function pointers, rather than having to
configure/prepare a fully-valid Plan and then infer the logic’s
correctness based on the Plan’s state.
* configuration that's specific to kubeconfig initialization is now part
of the InitKube struct rather than run.Config, since other steps
shouldn’t need access to those settings (particularly the secrets).
* Step.Execute now receives a run.Config so it can log debug output.
133 lines
2.8 KiB
Go
133 lines
2.8 KiB
Go
package run
|
|
|
|
import (
|
|
"fmt"
|
|
"github.com/golang/mock/gomock"
|
|
"github.com/stretchr/testify/suite"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
type UpgradeTestSuite struct {
|
|
suite.Suite
|
|
ctrl *gomock.Controller
|
|
mockCmd *Mockcmd
|
|
originalCommand func(string, ...string) cmd
|
|
}
|
|
|
|
func (suite *UpgradeTestSuite) BeforeTest(_, _ string) {
|
|
suite.ctrl = gomock.NewController(suite.T())
|
|
suite.mockCmd = NewMockcmd(suite.ctrl)
|
|
|
|
suite.originalCommand = command
|
|
command = func(path string, args ...string) cmd { return suite.mockCmd }
|
|
}
|
|
|
|
func (suite *UpgradeTestSuite) AfterTest(_, _ string) {
|
|
command = suite.originalCommand
|
|
}
|
|
|
|
func TestUpgradeTestSuite(t *testing.T) {
|
|
suite.Run(t, new(UpgradeTestSuite))
|
|
}
|
|
|
|
func (suite *UpgradeTestSuite) TestPrepare() {
|
|
defer suite.ctrl.Finish()
|
|
|
|
u := Upgrade{
|
|
Chart: "at40",
|
|
Release: "jonas_brothers_only_human",
|
|
}
|
|
|
|
command = func(path string, args ...string) cmd {
|
|
suite.Equal(helmBin, path)
|
|
suite.Equal([]string{"--kubeconfig", "/root/.kube/config", "upgrade", "--install",
|
|
"jonas_brothers_only_human", "at40"}, args)
|
|
|
|
return suite.mockCmd
|
|
}
|
|
|
|
suite.mockCmd.EXPECT().
|
|
Stdout(gomock.Any())
|
|
suite.mockCmd.EXPECT().
|
|
Stderr(gomock.Any())
|
|
suite.mockCmd.EXPECT().
|
|
Run().
|
|
Times(1)
|
|
|
|
cfg := Config{
|
|
KubeConfig: "/root/.kube/config",
|
|
}
|
|
err := u.Prepare(cfg)
|
|
suite.Require().Nil(err)
|
|
u.Execute(cfg)
|
|
}
|
|
|
|
func (suite *UpgradeTestSuite) TestPrepareNamespaceFlag() {
|
|
defer suite.ctrl.Finish()
|
|
|
|
u := Upgrade{
|
|
Chart: "at40",
|
|
Release: "shaed_trampoline",
|
|
}
|
|
|
|
command = func(path string, args ...string) cmd {
|
|
suite.Equal(helmBin, path)
|
|
suite.Equal([]string{"--kubeconfig", "/root/.kube/config", "--namespace", "melt", "upgrade",
|
|
"--install", "shaed_trampoline", "at40"}, args)
|
|
|
|
return suite.mockCmd
|
|
}
|
|
|
|
suite.mockCmd.EXPECT().
|
|
Stdout(gomock.Any())
|
|
suite.mockCmd.EXPECT().
|
|
Stderr(gomock.Any())
|
|
suite.mockCmd.EXPECT().
|
|
Run()
|
|
|
|
cfg := Config{
|
|
Namespace: "melt",
|
|
KubeConfig: "/root/.kube/config",
|
|
}
|
|
err := u.Prepare(cfg)
|
|
suite.Require().Nil(err)
|
|
u.Execute(cfg)
|
|
}
|
|
|
|
func (suite *UpgradeTestSuite) TestPrepareDebugFlag() {
|
|
u := Upgrade{
|
|
Chart: "at40",
|
|
Release: "lewis_capaldi_someone_you_loved",
|
|
}
|
|
|
|
stdout := strings.Builder{}
|
|
stderr := strings.Builder{}
|
|
cfg := Config{
|
|
Debug: true,
|
|
KubeConfig: "/root/.kube/config",
|
|
Stdout: &stdout,
|
|
Stderr: &stderr,
|
|
}
|
|
|
|
command = func(path string, args ...string) cmd {
|
|
suite.mockCmd.EXPECT().
|
|
String().
|
|
Return(fmt.Sprintf("%s %s", path, strings.Join(args, " ")))
|
|
|
|
return suite.mockCmd
|
|
}
|
|
|
|
suite.mockCmd.EXPECT().
|
|
Stdout(&stdout)
|
|
suite.mockCmd.EXPECT().
|
|
Stderr(&stderr)
|
|
|
|
u.Prepare(cfg)
|
|
|
|
want := fmt.Sprintf("Generated command: '%s --debug --kubeconfig /root/.kube/config upgrade "+
|
|
"--install lewis_capaldi_someone_you_loved at40'\n", helmBin)
|
|
suite.Equal(want, stderr.String())
|
|
suite.Equal("", stdout.String())
|
|
}
|