dentaku/woodpecker-helm3
1
0
Fork 0
Code Pull requests Releases Activity

Rely on the PR template for docs/code consistency [#12]

Browse source 
These comments were a reasonable attempt at ensuring the documentation
matched reality, but the checkbox in the pull request template is much
more likely to produce results.
This commit is contained in:
Erin Call 2019-12-26 13:03:53 -08:00
parent c0964ae178
commit 232bb5eb96
No known key found for this signature in database
GPG key ID: 4071FF6C15B8DAD1
3 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
internal/helm/plan.go
View file

@ -69,7 +69,6 @@ func determineSteps(cfg Config) *func(Config) []Step {
return &help return &help
default: default:
switch cfg.DroneEvent { switch cfg.DroneEvent {
// Note: These events are documented in docs/upgrade_settings.yml. Any changes here should be reflected there.
case "push", "tag", "deployment", "pull_request", "promote", "rollback": case "push", "tag", "deployment", "pull_request", "promote", "rollback":
return &upgrade return &upgrade
case "delete": case "delete":

2
internal/run/lint.go
View file

@ -16,8 +16,6 @@ func (l *Lint) Execute(_ Config) error {
} }
// Prepare gets the Lint ready to execute. // Prepare gets the Lint ready to execute.
// Note: mandatory settings are documented in README.md, and the full list of settings is in docs/lint_settings.yml.
// Any additions or deletions here should be reflected there.
func (l *Lint) Prepare(cfg Config) error { func (l *Lint) Prepare(cfg Config) error {
if l.Chart == "" { if l.Chart == "" {
return fmt.Errorf("chart is required") return fmt.Errorf("chart is required")

2
internal/run/upgrade.go
View file

@ -25,8 +25,6 @@ func (u *Upgrade) Execute(_ Config) error {
} }
// Prepare gets the Upgrade ready to execute. // Prepare gets the Upgrade ready to execute.
// Note: mandatory settings are documented in README.md, and the full list of settings is in docs/upgrade_settings.yml.
// Any additions or deletions here should be reflected there.
func (u *Upgrade) Prepare(cfg Config) error { func (u *Upgrade) Prepare(cfg Config) error {
if u.Chart == "" { if u.Chart == "" {
return fmt.Errorf("chart is required") return fmt.Errorf("chart is required")